Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bazelrc with some bazel 5.0 cache flags #2038

Merged
merged 1 commit into from
May 18, 2022
Merged

Update bazelrc with some bazel 5.0 cache flags #2038

merged 1 commit into from
May 18, 2022

Conversation

bduffany
Copy link
Member

@bduffany bduffany commented May 18, 2022 •
edited
Loading

This will give us some experience using these flags, since we are recommending them with the suggestions cards.

  • Enable --experimental_remote_cache_compression when running with --config=remote or --config=cache (does not apply to workflows since it's likely to be detrimental, and not to github CI either since it's unclear whether the network is a bottleneck there)
  • Enable --experimental_remote_cache_async and --incompatible_remote_build_event_upload_respect_no_cache unconditionally

Version bump: Patch

@bduffany bduffany merged commit 96eb286 into master May 18, 2022
@bduffany bduffany deleted the cache-flags branch May 18, 2022 21:22
@vadimberezniker
Copy link
Member

It looks like --incompatible_remote_build_event_upload_respect_no_cache also prevents logs from being uploaded when --noremote_upload_local_results is set. Is that intentional? I use --noremote_upload_local_results in my user bazelrc.

@brentleyjones
Copy link
Contributor

I believe so: bazelbuild/bazel#14338 (comment)

test logs are treated as action outputs. i.e. they are uploaded if the result of test actions can be uploaded. Or not uploaded if tagged with "no-cache".

@bduffany
Copy link
Member Author

Seems a bit unfortunate that the only way to upload test logs is to disable --noremote_upload_local_results, which I guess may upload a bunch of other unwanted stuff?

@brentleyjones
Copy link
Contributor

Correct. It's probably worth a Bazel GitHub issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siggisim siggisim siggisim approved these changes

@brentleyjones brentleyjones Awaiting requested review from brentleyjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bduffany @vadimberezniker @brentleyjones @siggisim